Don't modify project when snapping utils config is modified #36797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
changed the title
troopa81
added
backport release-3_10
Bug
nyalldawson
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36796
QgsSnappingUtils configuration is modified from snapToEditableLayer and so fire configChanged signal which modifies the project.
I remove the signal connection which was added in 5176ecf
The shortcut for toggle snapping seems to not exist anymore and modifying project snapping configuration should be done thanks to QgsProject method setSnappingConfig, not from QgsSnappingUtils.