Optimize unique values checks in QgsVectorLayerUtils #36866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unique constraint validation was sub-optimized in several points, this PR addresses a few of the critical paths all in QgsVectorLayerUtils - in createFeatures: on-demand creation of the cached values - in validateAttribute: don't check for uniqueness if the value is NULL and a NOT NULL constraint was violated - in valueExists: search source layers for values in joined fields Fixes qgis#36167
elpaso
added
the
Bug
nyalldawson
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique constraint validation was sub-optimized in several points,
this PR addresses a few of the critical paths all in QgsVectorLayerUtils
and a NOT NULL constraint was violated
Fixes #36167