Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize unique values checks in QgsVectorLayerUtils #36866

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Optimize unique values checks in QgsVectorLayerUtils #36866

merged 2 commits into from
Jun 2, 2020

Commits on Jun 1, 2020

  1. Optimize unique values checks in QgsVectorLayerUtils 

    Unique constraint validation was sub-optimized in several points,
this PR addresses a few of the critical paths all in QgsVectorLayerUtils

- in createFeatures: on-demand creation of the cached values
- in validateAttribute: don't check for uniqueness if the value is NULL
and a NOT NULL constraint was violated
- in valueExists: search source layers for values in joined fields

Fixes qgis#36167
    @elpaso
    elpaso committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    4ddee53 View commit details
    Browse the repository at this point in the history

  2. Missing import in test file

    @elpaso
    elpaso committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    7e3340a View commit details
    Browse the repository at this point in the history