Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-3_10] Windows GPKG project storage: fix path encoding #36993

Closed

Conversation

qgis-bot
Copy link
Collaborator

@qgis-bot qgis-bot commented Jun 5, 2020

Backport 42ea7bc from #36980

@github-actions github-actions bot added this to the 3.10.7 milestone Jun 5, 2020
@agiudiceandrea
Copy link
Contributor

@elpaso, it seems to me that the issue #36832 (at least the first reported behaviour) was not reproducible on 3.10.6 because #33265, which introduced the issue, was not backported to 3.10 afaik.
Is it safe to backport this fix to 3.10? without backporting also #33265?

@elpaso
Copy link
Contributor

elpaso commented Jun 5, 2020

@agiudiceandrea the real fix turned out to be https://github.com/qgis/QGIS/pull/36993/files#diff-f333e375c59b5479cf267e8d70180df7R383

The root of the problem was the way the connection path is stored when a new connection is automatically created after the user creates a new GPKG (i.e. \ was used instead instead of /, which is supported on windows too).

I checked 3.10 and the code is the same so I think it's safe to backport. Are you sure the issue does not exist in 3.10?

It can be checked by creating a new GPKG, opening the settings file of the active profile and checking for the path stored in for the newly created GPKG stored connection: if it uses \ then we have the problem.

A manual test of this backport after merge would be appreciated as well.

@nyalldawson nyalldawson added the NOT FOR MERGE Don't merge! label Jun 7, 2020
@nyalldawson nyalldawson modified the milestones: 3.10.7, 3.10.9 (LTR) Jun 7, 2020
@nyalldawson
Copy link
Collaborator

Lets queue this for 3.10.9 to give plently of time for testing in 3.14 then...

@nyalldawson
Copy link
Collaborator

Moved to #36812

@nyalldawson nyalldawson closed this Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT FOR MERGE Don't merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants