it is not possible to save a project in the geopackage

[pigreco]

Starting from a new profile in QGIS MASTER, I can't save the project in a newly created geopackage.

how to reproduce the problem

1. create a new geopackage from the browser panel
2. import a vector into the geopackage
3. load the vector into a new project
4. save the project
5. it is not possible to save it, URI error appears !!!

video demo master 3.13.55:
https://www.loom.com/share/1ff8fbc3e36a4a6888ce12ab35122ceb

OSGeo4W64

the problem is present in all versions 3.10, 3.12 and master

[agiudiceandrea]

Hi @pigreco, I've tested the procedure using QGIS 3.10.6 and QGIS 3.12.3 (standalone installers) on Windows 10 and it seems the bug is only in QGIS 3.12.3, while QGIS 3.10.6 stores the project into the GeoPackage without problem.
Are you experiencing the bug also using QGIS 3.10?

[pigreco]

Are you experiencing the bug also using QGIS 3.10?

I did the same test (profile not new) in 3.10.6 and with new geopackage , it works!

But if I use an old geopackage, I can't save the project.

For 3.12 it is not important, it will be out soon, but in the master the problem persists.

Thanks for your interest.

--
video demo 3.10.6
https://www.loom.com/share/09822322731b4eb7bb8bbbfecfb987c4

--

EDIT

in 3.10.6, if I try to save a project in a geopackage created in another work session

[pigreco]

other comments:

1. if I save the project in geopackage using 3.10.6, I see the project:

2. but I don't see it in 3.13 (master)

3. QGIS 3.12.3 I do not see the project
   

geopackage

materiale_didattico.zip

[gioman]

if I save the project in geopackage using 3.10.6, I see the project:

@pigreco this would be a different issue that needs a separate ticket. Also is similar to #33057

[gioman]

For 3.12 it is not important, it will be out soon, but in the master the problem persists.

@pigreco with QGIS master on Linux I'm able to save a project in your GPKG https://github.com/qgis/QGIS/files/4705440/materiale_didattico.zip At the end of the operation the project shows in the QGIS Browser and loads as expected.

[pigreco]

@pigreco this would be a different issue that needs a separate ticket. Also is similar to #33057

you are probably right, but I am noticing some problems and I am trying to make them present to help @elpaso

[elpaso]

@pigreco is this problem only on windows?

[pigreco]

@pigreco is this problem only on windows?

i only use windows
can I ask friends to do the same test on linux.

I update you

[elpaso]

It's working fine on Linux, so let's assume it's windows-only for now.

[albertograva]

I've tested in ubuntu 18.04 with 3.12.3-București and I can confirm that it works.

[gioman]

@pigreco and it works fine also on master on Windows here...

[gioman]

@pigreco and on 3.12/Windows too...

[pigreco]

@pigreco and on 3.12/Windows too...

I can't, maybe it's just my problem!

[gioman]

I can't, maybe it's just my problem!

@pigreco I would suggest having a completely clean Virtual Machine (you can download the Windows ISO from the MS site) and use to double check if what you are seeing on your work machine confirms or not.

[pigreco]

@gioman

your suggestion is good,
but before venturing into a virtual machine I would wait for another test on windows from a third person.
thanks

[gioman]

but before venturing into a virtual machine

@pigreco you do much more difficult things with QGIS and databases... ;)

[pigreco]

perhaps I abandon the idea of saving the project file in the geopackage. :-(

[agiudiceandrea]

Hi @pigreco, @elpaso, @gioman, as previously already reported, I can confirm the first described bug, following the described procedure with alaska.shp as layer, occurring on Windows 10 64 bit using QGIS 3.12.3 (standalone installer) with a new clean profile:

It also occurs using QGIS 3.13.0-Master code revision 81abbbb May 29th 2020 (OSGeo4W installer):

It doesn't occur using QGIS 3.10.6 (standalone installer):

[gioman]

the described procedure

Then maybe the described procedure is not clear. Can you tell what are the steps to follow?

[agiudiceandrea]

I've just followed these #36832 (comment) very steps:

1. create a new geopackage ["test.gpkg" in "C:\TEST\", with a no geometry table named "test"] from the browser panel [the Geopackage is created, a new connection is automatically created ad appears under the GeoPackage node in the Browser panel, the table "test" is automatically added as layer in the current project "Untitled Project"]
2. import a vector into the geopackage [in the Browser panel, drag a vector layer (in this case, "C:\TEST\alaska.shp" from https://qgis.org/downloads/data/qgis_sample_data.zip) and drop it into the GeoPackage "test.gpkg" under the GeoPackage node]
3. load the vector into the project [drag and drop the layer "alaska" from the "test.gpkg" geopackage under the GeoPackage node to the Layers panel, or simply double click the layer "alaska" in "test.gpkg"]
4. save the project [using Project->Save To->GeoPackage..., select the already connect "test.gpkg" GeoPackage and enter a name for the project to save, e.g. "test_project"]

then the project is not saved and an error window is displayed with the following text:

Unable to save project to storage geopackage:C:%5CTEST%5Ctest.gpkg?projectName=test_project

Unable to insert or update project (project=geopackage:C:%5CTEST%5Ctest.gpkg?projectName=test_project) in the destination table on the database: Invalid URI for GeoPackage OGR provider: C:\TEST\test.gpkg

[agiudiceandrea]

I suppose this regression could be due to a change in QgsGeoPackageProjectStorage between 3.10 and 3.12.
Maybe 3dcbde9 (#33265)?

[gioman]

@agiudiceandrea seen the error. What it makes the difference if is the connection to the GPKG is added manually or automatically as described in step 1. If the connection created in step1 is removed, then re-created manually then it works as expected.

[elpaso]

@agiudiceandrea pretty unlikely because that was exactly what I was testing (besides the shares paths). I'm more thinking at a side effect of other issues that I'm fixing now #36972

@gioman can you please clarify? I couldn't reproduce on windows master with the instructions above (I'm not using a network share either).
Do you have a clear path to reproduce this on windows?

[agiudiceandrea]

If the connection created in step1 is removed, then re-created manually then it works as expected.

I can confirm.
It also doesn't occur if the new GeoPackage is created using "New GeoPackage Layer..." (because in this case the connection needs to be made manually).

I'm more thinking at a side effect of other issues that I'm fixing now #36972

I think I've spotted your issue during the test in my previous screencast (here an excerpt) with 3.13-master (but not with 3.12.3, nor 3.10.6):

Anyway, I can reproduce the original issue without using drag and drop and without importing any layer in the GeoPackage.

Here a minimum set of steps to reproduce the bug:

1. create a new geopackage ["test.gpkg" in "C:\TEST", with a no geometry table named "test"] from the browser panel [the Geopackage is created, a new connection is automatically created ad appears under the GeoPackage node in the Browser panel, the table "test" is automatically added as layer in the current project "Untitled Project"]
2. save the project [using Project->Save To->GeoPackage..., select the already connect "test.gpkg" GeoPackage and enter a name for the project to save, e.g. "test_project"]

then the project is not saved and an error window is displayed with the following text:

Unable to save project to storage geopackage:C:%5CTEST%5Ctest.gpkg?projectName=test_project

Unable to insert or update project (project=geopackage:C:%5CTEST%5Ctest.gpkg?projectName=test_project) in the destination table on the database: Invalid URI for GeoPackage OGR provider: C:\TEST\test.gpkg

In this error message there is no mention of "gpkg:/".

[gioman]

Do you have a clear path to reproduce this on windows?

@elpaso is as @agiudiceandrea said, create a new database from the browser > it will auto-add a connection. At this point saving a project using this connection will fail. If you remove that connection and recreate it manually it will work.

[elpaso]

@agiudiceandrea and you were right ... it's a side effect of the network patch. I'm able to reproduce it now.

[agiudiceandrea]

Maybe changing

QGIS/src/core/providers/ogr/qgsgeopackageprojectstorage.cpp

Line 255 in 5aecd49

errCause = _executeSql( projectUri.database, sql );

to
errCause = _executeSql( uri, sql );

like is in

QGIS/src/core/providers/ogr/qgsgeopackageprojectstorage.cpp

Line 222 in 5aecd49

errCause = _executeSql( uri, QStringLiteral( "CREATE TABLE qgis_projects(name TEXT PRIMARY KEY, metadata BLOB, content BLOB)" ) );

could fix the issue?

[elpaso]

@agiudiceandrea nope, the root of the issue is in QgsGeoPackageItemGuiProvider::createDatabase(), I have a patch but testing on windows takes ages on my dev machine ... slow, tedious and boring ...

Have a look to the settings file and you will see that depending on how you store the connections it is stored ad C:/.... or C:\.... and that makes all the difference in the URI encoding.

[elpaso]

@agiudiceandrea anyway I'll check if that difference in _executeSql make sense.

[elpaso]

I'd really like some tests from the windows users on this patch:
#36980
What to test:

• create gpkgs in different ways and add connections to existing gpkgs from various sources (C:, network shares starting with // etc.)
• create a project and store it into the gpkgs
• check the operations (delete, update etc.)

The problems are due to the different ways windows uses to store paths, I put code in place to normalize it but there are no automated tests.

[pigreco]

I'd really like some tests from the windows users on this patch:
#36980

how do i test ??
what should i download ??

[elpaso]

@pigreco wait for the nightly build please, MXE builds are unfortunately no longer available.

[pigreco]

Good morning,
I did a test using the master
IT WORKS!!!

here is a video.
https://www.loom.com/share/9c9beb015a6849b5964256250fd7a8e2
thank you very much