Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "markers" terminology consistently in centroid fill widget #37143

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Use "markers" terminology consistently in centroid fill widget #37143

merged 2 commits into from
Jun 15, 2020

Conversation

nyalldawson
Copy link
Collaborator

Fixes #37106

@nyalldawson nyalldawson added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Jun 11, 2020
@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions github-actions bot added this to the 3.14.0 milestone Jun 11, 2020
nirvn
nirvn approved these changes Jun 12, 2020
View reviewed changes
src/ui/symbollayer/widget_centroidfill.ui Outdated
</layout>
<widget class="QCheckBox" name="mDrawAllPartsCheckBox">
<property name="toolTip">
<string>When unchecked, a single point will be drawn on the biggest part of multi-part features</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When unchecked, a single point -> a single marker?

@nyalldawson nyalldawson merged commit 4fd98e3 into qgis:master Jun 15, 2020
@nyalldawson nyalldawson deleted the fix_37106_markers branch June 15, 2020 06:31
@qgis-bot qgis-bot mentioned this pull request Jun 15, 2020
Closed
@qgis-bot
Copy link
Collaborator

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#5712
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirvn nirvn nirvn approved these changes

Assignees
No one assigned
Labels
Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

Harmonize terms used in the centroid fill symbol dialog
3 participants
@nyalldawson @qgis-bot @nirvn