Expression preview widget: do not disable feature picker (fixes #38646) #38797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…38646) In the text edit of the feature picker, if one currently enters an invalid value, the whole feature picker becomes disabled, which requires to close and re-open the expression string builder dialog. So instead of doing this, use the preview label to indicate that a valid feature is needed to evaluate the expression, for expressions that require feature fields. Previous related pull requests are: qgis#37518 qgis#37139
rouault
added
the
Bug
3nids
reviewed
Sep 16, 2020
| if ( !feature.isValid() ) | ||
| { | ||
| QgsFeature validFeature( feature ); | ||
| validFeature.setValid( true ); |
There was a problem hiding this comment.
if you remove this, that will bring back the issue when a layer is empty and you try an expression (#37100).
Or am I missing something?
There was a problem hiding this comment.
With this pull request, if the layer is empty (or you specify an invalid FID),
- if the expression doesn't use fields, then it is evaluated
- if the expression uses fields, the preview label displays "No feature was found on this layer to evaluate the expression" (not that the expression is invalid)
3nids
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the text edit of the feature picker, if one currently enters an invalid value,
the whole feature picker becomes disabled, which requires to close and re-open
the expression string builder dialog.
So instead of doing this, use the preview label to indicate that a valid
feature is needed to evaluate the expression, for expressions that require feature
fields.
Previous related pull requests are:
#37518
#37139