disable feature picker when no feature is available in expression preview widget #37518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not hide it also? |
|
I tend to prefer to disable rather than hiding but no strong opinion. |
m-kuhn
reviewed
Jul 6, 2020
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
rouault
added a commit
to rouault/QGIS
that referenced
this pull request
Sep 16, 2020
…38646) In the text edit of the feature picker, if one currently enters an invalid value, the whole feature picker becomes disabled, which requires to close and re-open the expression string builder dialog. So instead of doing this, use the preview label to indicate that a valid feature is needed to evaluate the expression, for expressions that require feature fields. Previous related pull requests are: qgis#37518 qgis#37139
nyalldawson
pushed a commit
that referenced
this pull request
Sep 16, 2020
In the text edit of the feature picker, if one currently enters an invalid value, the whole feature picker becomes disabled, which requires to close and re-open the expression string builder dialog. So instead of doing this, use the preview label to indicate that a valid feature is needed to evaluate the expression, for expressions that require feature fields. Previous related pull requests are: #37518 #37139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following discussion in #37139 (comment)