Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding AMS layers even if project has no CRS #38893

Closed
wants to merge 1 commit into from

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Sep 20, 2020

The uri for AMS layers are separated by spaces instead of the usual &.
No surprise that hacks are not that robust.

Fixes #38892

@github-actions github-actions bot added this to the 3.16.0 milestone Sep 20, 2020
@nyalldawson
Copy link
Collaborator

This is super fragile -- it breaks CRS which are defined using wkt strings alone. Oh well, that's not a regression introduced here...!

@nyalldawson
Copy link
Collaborator

Actually this code and logic in crsAndFormatAdjustedLayerUri is horrible in general...!

@m-kuhn
Copy link
Member Author

m-kuhn commented Sep 21, 2020

I agree. Do you want to propose a better API?

@stale
Copy link

stale bot commented Oct 11, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 11, 2020
@stale
Copy link

stale bot commented Nov 7, 2020

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMS layers not loaded if project has no CRS
2 participants