Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message log dock causes havoc with other docks placed in the same area #39192

Merged

Conversation

nyalldawson
Copy link
Collaborator

Fixes #31955, fixes #27868, fixes #39171

@github-actions github-actions bot added this to the 3.16.0 milestone Oct 6, 2020
@nyalldawson nyalldawson merged commit 384f6a1 into qgis:master Oct 6, 2020
@nyalldawson nyalldawson deleted the fix_31955_log_message_behavior branch October 6, 2020 07:03
@rduivenvoorde
Copy link
Contributor

Thanks @nyalldawson! Build and tested.

One minor visual issue: the little bubble button becomes active/nonactive if you click it it self.
But if you use the contextmenu to show/hide the log messages panel, the bubble button active state is not updated...
I can live with it :-) But thought to let know.

@rduivenvoorde
Copy link
Contributor

Nice headtrick by the way: closing 3 issues \o/

@nyalldawson
Copy link
Collaborator Author

@rduivenvoorde I can't reproduce that -- could you share a screencast?

@rduivenvoorde
Copy link
Contributor

More info (my screencast plugin just broke...):
it is because if you use the context menu to hide/show the Log Messages, it does NOT get focus.
And the little balloon button is only 'active' if the actual Log Messages TAB is in focus.
Difference is that with the balloonbutton you show the messages AND it get's focus
with context menu you only add the messages to the tab list but (in my case) the Temporal Controller stays in focus
This more clear?

@nyalldawson
Copy link
Collaborator Author

Which context menu are you using?

@rduivenvoorde
Copy link
Contributor

Right click in empty place of toolbar (to enable Panels and Toolbars)
Screenshot-20201006115212-469x1003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants