Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate qgis_process params with -- #39349

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Oct 13, 2020

Description

Collision free parameters for qgis_process by separating executable args and algorithm args with --

qgis_process run algname --distanceUnits=meters -- PARAM1=23 PARAM2=/path/to/file distanceUnits=someOtherParam

Still supports the legacy version using --PARAM=VALUE syntax

@nyalldawson looking for your feedback before finetuning

@github-actions github-actions bot added this to the 3.16.0 milestone Oct 13, 2020
@nyalldawson
Copy link
Collaborator

Looks good! There's tests for this tool also which will need extending (also the docs)

@m-kuhn
Copy link
Member Author

m-kuhn commented Oct 14, 2020

CC @stibu81 how does this look to you?

@m-kuhn m-kuhn added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Oct 14, 2020
@qgis-bot
Copy link
Collaborator

@m-kuhn
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@m-kuhn
A documentation ticket has been opened at qgis/QGIS-Documentation#6192
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@stibu81
Copy link

stibu81 commented Oct 15, 2020

CC @stibu81 how does this look to you?

@m-kuhn This looks like an excellent idea! Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants