Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for polymorphic relations relations #40914

Merged
merged 18 commits into from Jan 14, 2021
Merged

Added support for polymorphic relations relations #40914

merged 18 commits into from Jan 14, 2021

Conversation

suricactus
Copy link
Contributor

@suricactus suricactus commented Jan 8, 2021 •
edited

This PR contains the core changes to support the polymorphic relations as described in qgis/QGIS-Enhancement-Proposals#79 .

Related also to:
#40721

TODOs:

  • support evaluating the layer expression
  • basic unit tests
  • A follow up PR will be opened with the UI to setup a new polymorphic relation

@github-actions github-actions bot added this to the 3.18.0 milestone Jan 8, 2021
@suricactus suricactus force-pushed the dms_core branch 2 times, most recently from 481d3fb to dfb0688 Compare January 8, 2021 21:03
@suricactus suricactus marked this pull request as draft January 8, 2021 21:05
suricactus
suricactus commented Jan 12, 2021
View reviewed changes
src/core/qgsrelation.cpp Outdated Show resolved Hide resolved
m-kuhn
m-kuhn reviewed Jan 12, 2021
View reviewed changes
Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks solid to me, good job.
Some comments left inside, but overall no big questions left.

src/core/qgsrelationmanager.cpp Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation.h Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation.cpp Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation.cpp Show resolved Hide resolved
src/core/qgspolymorphicrelation.cpp Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation_p.h Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation_p.h Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation.h Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation.h Outdated Show resolved Hide resolved
src/core/qgspolymorphicrelation.h Outdated Show resolved Hide resolved
@suricactus suricactus marked this pull request as ready for review January 12, 2021 21:57
@suricactus
Copy link
Contributor Author

suricactus commented Jan 13, 2021 •
edited 

toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
The command "./.ci/travis/${TRAVIS_CONFIG}/before_script.sh" failed and exited with 1 during .```

:(

@m-kuhn m-kuhn merged commit 26361a9 into qgis:master Jan 14, 2021
@suricactus suricactus mentioned this pull request Jan 14, 2021
Merged
@troopa81 troopa81 mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso left review comments

@m-kuhn m-kuhn m-kuhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suricactus @elpaso @m-kuhn