Document management system a.k.a. polymorphic relations GUI #41009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3nids
added
the
Needs Documentation
3nids
reviewed
Jan 15, 2021
3nids
approved these changes
Jan 15, 2021
3nids
approved these changes
Jan 15, 2021
nyalldawson
added
Changelog
|
Unrelated test failures |
|
Looks like the "needs-documentation" bot is also broken. This PR did not create the expected issue report. |
|
I will do this and qgis/QGIS-Documentation#6435 in one go. |
|
No worries @suricactus. My comment was more an issue report than a doc request. |
zacharlie
added
ChangelogHarvested
|
@suricactus Playing with cppcheck, I stumble upon this. It looks like a possible issue right here, no? |
suricactus
added a commit
to suricactus/QGIS
that referenced
this pull request
Apr 29, 2022
…lidation As pointed in qgis#41009 (comment) there was an early return that was probably a leftover from local tests and somehow passed the review. To facilitate proper validation, a new event had to be added on the `referencingField` combo, which triggers the form validation and enabling the ok button respectively. Thank you @troopa81 for bringing my attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GUI to manage polymorphic relations, last followup of my previous two PRs related to implementing qgis/QGIS-Enhancement-Proposals#79 , see #40721 and #40914 .
The "Add relation" button in the relation manager screen now has additional option to add/edit polymorphic relations:
The "Add polymorphic relation" and "Edit polymorphic relation" open the same dialog, in the latter case with predefined values:
The "Add relation" dialog has been updated, now it uses the same table with buttons on the right layout as most of the QGIS UI. Other than UI, there are no other changes here.
Once saved, the list of relations appear as a tree widget, where the generated normal relations for a polymorphic relation appear as children. The names of the generated relations cannot be changed.
When saving the
.qmlstyle of the layer, the generated relations are not stored, since they are generated from their polymorphic relation every time the project is opened. The polymorphic relations are not exported either, at least for now.