Fix use of Sum Line Length and Count Points in Polygons in in-place mode #41321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in place algorithms through locator filter
always fixed, so ensure we correctly obtain and use the correct input parameter name
Sum Line Length and Count Points In Polygons result fields when running in in-place mode Makes these algorithms fully compatible with in place execution Fixes qgis#39807
nyalldawson
added
Processing
nirvn
approved these changes
Feb 3, 2021
|
Unrelated test failures |
|
Thanks @nyalldawson but as mentioned by @DelazJ I disabled in-place mode for theses algorithms since they added fields which is not allowed -- At least that's what it is written in the doc: "They do not change the layer structure, e.g. adding or removing fields." Has there been a change, are changes allowed on layers now? |
|
@lbartoletti yes -- if the algorithm is setup correctly, then when its run in in-place mode the user should be prompted for existing fields in which to store generated values (as is done in this PR) |
|
I saw #41315 last night and came to point the use case of utilizing existing fields, but @nyalldawson you rock! |
|
Is there anything we should tweak in the docs or is it not worth it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #41315 -- instead of disabling in-place mode for these algorithms, make the algorithms fully compatible with in-place edit modes.