Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] improve graphs #4150

Merged
merged 8 commits into from
Feb 16, 2017
Merged

[processing] improve graphs #4150

merged 8 commits into from
Feb 16, 2017

Conversation

alexbruy
Copy link
Contributor

Use Plotly to generate interactive graphs (zooming, selecting, panning etc).

@alexbruy alexbruy requested a review from volaya February 15, 2017 18:12
@alexbruy alexbruy merged commit f587ae5 into qgis:master Feb 16, 2017
@alexbruy alexbruy deleted the processing-graphs branch February 16, 2017 12:42
@ghtmtt
Copy link
Contributor

ghtmtt commented Feb 17, 2017

are you serious?! We can use plotly to make plot within Processing?! This is AWESOME!
Anyway, I cannot see the plots in the toolbox yet.. Is the package plotly automatically installed?
Thanks Alex!

@luipir
Copy link
Contributor

luipir commented Feb 17, 2017

@ghtmtt you need plotly python module installed... and them thi PR will substitute the matplotlib plot engine that was used before in the graph result window

@ghtmtt
Copy link
Contributor

ghtmtt commented Feb 18, 2017

@luipir ah ok I see... So the user has to install plotly by him self right? Will the package be in the default installation in the future (so like numpy)?
Thanks Luigi and Alex!

@ghtmtt
Copy link
Contributor

ghtmtt commented Feb 20, 2017

@luipir @alexbruy as I said, this is really a great PR! In Girona, together with @mdouchin we tried to make a plugin using Plotly.
However, IMHO, if the user has to install by himself plotly via pip then the users that will discover the plots drop down.
So the question is, is in planned to put plotly package directly in the source code (so like the other current python external packages)?

Thanks again for this Alex!

@luipir
Copy link
Contributor

luipir commented Feb 20, 2017

@ghtmtt this is a packaging problem more than a coding problem... plotly can be added as was added matplotlib. I can't find limitation to add plotly as new dependecy

@ghtmtt
Copy link
Contributor

ghtmtt commented Feb 20, 2017

thanks @luipir for clarifying.. So there are plans to add plotly as default dependency right?
Thanks again

@jef-n
Copy link
Member

jef-n commented Feb 20, 2017

done in a217181 - and included in OSGeo4W

@alexbruy
Copy link
Contributor Author

Just to clarify, plotly is not a hard requirement. Processing will work without it too, as it did when matplotlib was used.

@ghtmtt
Copy link
Contributor

ghtmtt commented Feb 20, 2017

@jef-n thanks for this!
@alexbruy yes it works also without plotly but it's a pity not using it ;) thanks again for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants