Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow callouts to be interactively moved using Move Label tool #41724

Merged
merged 6 commits into from
Feb 23, 2021

Conversation

nyalldawson
Copy link
Collaborator

(Builds off #41718)

This change allows the interactive "Move labels" tool to also move callout endpoints, whenever the callout has data defined origin or destination fields set:

Peek 2021-02-22 12-51

@nyalldawson nyalldawson added Feature Labeling Related to QGIS map labeling labels Feb 22, 2021
@github-actions github-actions bot added this to the 3.20.0 milestone Feb 22, 2021
@roya0045
Copy link
Contributor

Do the names have to be set before moving?

@nyalldawson
Copy link
Collaborator Author

Do the names have to be set before moving?

Yep -- I'll see if this can be changed at a later stage

@roya0045
Copy link
Contributor

I feel like that may be related to the datadatefined settings just being set as invalid when copy-pasting symbology, where you have to open the dialog and close it to make it work again.

Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

using the Move Labels tool

Allows users to manually place the exact start or end point of label
callout lines.

*Callouts must have a data defined origin/destination
field set to permit this.
Means that if the cad dock is enabled, callout lines will auto-snap
to nice angles, etc.
@nyalldawson nyalldawson merged commit b15be66 into qgis:master Feb 23, 2021
@nyalldawson nyalldawson deleted the callout_move branch February 23, 2021 05:49
@zacharlie zacharlie added the ChangelogHarvested This PR description has been harvested in the Changelog already. label Jun 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Labeling Related to QGIS map labeling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants