WMS cascading: fix unreported issue wih missing fids #42100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. in WMS provider try to set fid from external getFeatureInfo JSON response 2. in WMS server, make sure we transform integer FID to string This fixes an unreported issue where getFeatureInfo from cascaded WMS in JSON format have no feature IDs. Funded by Gis3W https://www.gis3w.it
elpaso
added
Bug
nyalldawson
reviewed
Mar 8, 2021
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
…-fid WMS cascading: fix unreported issue wih missing fids
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
…-fid WMS cascading: fix unreported issue wih missing fids
nyalldawson
pushed a commit
that referenced
this pull request
Mar 11, 2021
…-fid WMS cascading: fix unreported issue wih missing fids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unreported issue where getFeatureInfo from cascaded WMS in
JSON format have no feature IDs.
Funded by Gis3W https://www.gis3w.it