Show paper properties if clicked on a Layout Page #42572
Conversation
Currently the only way to see the current Page properties (most notably the page orientation and size) is via a context menu. In my experience several people failed to 'find' it. Now if you click on a page the props will be shown (just like if you use the context menu).
| else | ||
| { | ||
| if ( paperItem ) |
There was a problem hiding this comment.
can't this be a single else if?
There was a problem hiding this comment.
Mmm, probably yes, the loop is entered a couple of times, not sure why, but indeed this could be an else if
|
Does it work fine with multipages and when clicking in the void? |
|
Though this seems to still require an empty spot to work. The proper solution may be to have a dedicated panel and have it change in a similar way as this, i.e.: the values changed depending on the position of the click, regardless of the widgets selected. |
If you mean with 'multipages' a layout in which you added some pages via 'layout/Add Pages', then yes. To check: give your pages a different background color and after that click on them to see it change with you clicked page.
I have thought about a dedicated panel, but this works just in exact the same way as when you use the context menu. And a 'QgsLayoutItemPage' is also a 'QgsLayoutItem', only difference is you do not see it 'selected' (and it does not show up in the 'selectedItemList'. |
|
Sounds good to me. It's obviously an issue for some users, and we haven't seen any sponsorship yet to implement a proper "page manager" dock to handle this nicely. |
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
|
Accepted your suggestions (indeed cleaner/nicer). Argh... used github for it... not checking code layout...
I've been thinking about that too: a separate page tab, but as the old context menu also just reused the Item Properties, I thought to keep it like this: small and simple and working (for me :-)). One thing: what is the meaning of the Layout/Page Setup menu? Because that is where people also try to change the page orientation and size... |
it's for printer page setup. We could rename it as "Printer Setup" or "Printer Page Setup" maybe? |
|
Mmm, code layout still failing, but running astyle and prepare_commit do not reveal anything? |
Yep! Good idea! Will do |
People sometimes tried to setup page orientation there in my experience. This makes it more clear that it is only for printing pages.
| @@ -1127,7 +1127,7 @@ | |||
| </property> | |||
| </action> | |||
| <action name="mActionShowPage"> | |||
| <property name="checkable">q | |||
There was a problem hiding this comment.
Apparently this 'q' was removed by QtDesigner/Creator?? Is that a vim-left over? Or did it really do something?
| <include location="../../../images/images.qrc"/> | ||
| <include location="../../../images/images.qrc"/> | ||
| <include location="../../../images/images.qrc"/> | ||
| <include location="../../../images/images.qrc"/> |
There was a problem hiding this comment.
Mmmm... strange 'cleanup'?
|
I also tried to change the Dialog Title of the 'Page Setup', but that seems to be a Qt dialog. |
nyalldawson
added
the
Needs Documentation
|
@rduivenvoorde A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
|
@rduivenvoorde |
Currently the only way to see the current Page properties (most
notably the page orientation and size) is via a context menu.
In my experience several people failed to 'find' it.
See also: https://lists.osgeo.org/pipermail/qgis-developer/2021-March/063416.html
and #26237 (could be closed) and #25803
Took me some time to follow/understand all mouse pressed/move/released signals :-)
But I think this commit is a pretty clean solution?
Now if you click on a page the props will be shown (just like
if you use the context menu).