Catch geos exception in main event loop #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me... I've also hit random GEOS exceptions which I just can't pinpoint, so anything that gives more clues as to their source is welcome! |
|
Actually... We should probably update and use QgsException and catch a stacktrace in the constructor when compiled in debug mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something fails to catch a geos exception, at least there will be more information in the message box.
I hope to get more information next time I run into this reshape tool shows "Unknown Exception" message possibly related to CRS and snapping but not sure and cannot reproduce error.
I am not sure what exactly the reason was for GEOSException implementing a static
lastMsgvariable. It looks like this is only assigned but never used and is some really old code.