Add basic support for coordinate epoch of dynamic (not plate fixed) crs #43188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to QgsCoordinateTransform QgsCoordinateTransform class can perform time-dependent transformations between a static and dynamic CRS based on either the source OR destination CRS coordinate epoch, however dynamic CRS to dynamic CRS transformations are not currently supported. Using the same approach as the GDAL changeset in OSGeo/gdal#3810
dynamic CRSes at different coordinate epochs is attempted This is not currently supported by PROJ, so the results will be misleading.
nyalldawson
added
Projections/Transformations
|
@rouault can I get your eyes on this one please? |
rouault
reviewed
May 12, 2021
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
rouault
approved these changes
May 13, 2021
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #43143, and add support for respecting the source OR destination coordinate epoch when transforming to/from dynamic CRS.
Uses the same approach as OSGeo/gdal#3810
If a dynamic crs -> dynamic CRS transform at different epochs is attempted (not currently supported by PROJ), a user facing warning message will be shown advising them that the results may be misleading and should not be used for high accuracy work.