Do not monitor remote/network directories by default in browser, allow users to opt-in to this #43416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
items should be automatically monitored for changes This monitoring can be expensive for some locations (eg network folders or cloud based directories), so in these cases it is desirable to allow it to be disabled to avoid hangs in the QGIS application.
to allow users to explicit control whether a directory is automatically monitored for changes.
are slow Effectively this means that the browser no longer defaults to watching network and remote drives (on Windows) for changes. This is expensive to do and can result in large hangs in the QGIS application. Users can still manually opt-in to monitoring of these locations through the context menu of the directory in the browser panel.
nyalldawson
added
QGIS Browser
Needs Documentation
|
@nyalldawson A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
|
Any takers for a review here? |
nirvn
approved these changes
May 31, 2021
|
@nyalldawson |
This was referenced Jun 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic used to determine whether a directory item in the browser panel will be automatically monitored for changes. This automatic monitoring is expensive to do in some circumstances (e.g. for network drives or cloud based drives), and has been a cause of long reported hangs in the QGIS interface.
Now:
Together these changes should help improve QGIS responsiveness when used in remote/work-from-home environments.