Fix return value of addTopologicalPoints(QgsGeometry) #43854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gacarrillor
changed the title
gacarrillor
force-pushed
the
addtopologicalpoints_results
branch
from
0c5f58b
to
6e2a9fe
Compare
gacarrillor
changed the title
|
Thanks @gacarrillor I'll try to review it this week. |
lbartoletti
reviewed
Jul 5, 2021
lbartoletti
reviewed
Jul 5, 2021
lbartoletti
reviewed
Jul 5, 2021
…ests for error result codes (-1 and 1)
gacarrillor
force-pushed
the
addtopologicalpoints_results
branch
from
cc8cf03
to
92231d7
Compare
Thanks for your review @lbartoletti! |
m-kuhn
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QgsVectorLayerEditUtils.addTopologicalPoints(QgsGeometry)iteratesQgsGeometryvertices. It's currently returning a 2 (2: No vertex added) if at least one point wasn't added. Instead, it should return 0 (0: Success) if at least one point was added.So, I'm taking the same logic than in addTopologicalPoints(QgsPointSequence) to fix such behavior.
I'll add some tests for that.