Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] Fix file download alg stuck in infinit loop when network errors occur #44094

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jul 9, 2021

Description

This PR fixes a bug whereas the file downloader algorithm gets stuck in an infinite loop when network errors occur. Long story short here: do not throw when inside an event loop and expect things will terminate properly :)

@nirvn nirvn added Processing Relating to QGIS Processing framework or individual Processing algorithms Bug Either a bug report, or a bug fix. Let's hope for the latter! backport queued_ltr_backports Queued Backports backport release-3_20 labels Jul 9, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Jul 9, 2021
@Gustry
Copy link
Contributor

Gustry commented Jul 9, 2021

Thanks for this fix.
I just got it yesterday as well.

@rouault rouault merged commit 2071cd8 into qgis:master Jul 10, 2021
@qgis-bot
Copy link
Collaborator

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-44094-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 4f6f4be425e77446cda063b116ba49124a5486d0
# Push it to GitHub
git push --set-upstream origin backport-44094-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-44094-to-queued_ltr_backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants