Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geojson attr table field order #45174

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 21, 2021

Fixes #45139

See GH issue #45139 for the long explanation.

Fixes qgis#45139

See GH issue qgis#45139 for the long explanation.
@elpaso elpaso added Data Provider Related to specific vector, raster or mesh data providers Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Sep 21, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Sep 21, 2021
@elpaso
Copy link
Contributor Author

elpaso commented Oct 6, 2021

@rouault should we close this one because fixed upstream?

@rouault
Copy link
Contributor

rouault commented Oct 6, 2021

should we close this one because fixed upstream?

isn't that a robustness fix that could also be worth in other contexts ?
Note:: there are 3 modified .gpkg files in tests/testdata that should be reverted

@elpaso
Copy link
Contributor Author

elpaso commented Oct 6, 2021

should we close this one because fixed upstream?

isn't that a robustness fix that could also be worth in other contexts ?

In theory yes but the test doesn't cover any other issue than the one fixed upstream and nobody reported any issue with other data sources. BTW I'm a +0 for merging.

Note:: there are 3 modified .gpkg files in tests/testdata that should be reverted

I'll fix that.

@elpaso elpaso force-pushed the bugfix-gh45139-geojson-field-order branch from 279a892 to d7af7d2 Compare October 14, 2021 11:57
@elpaso
Copy link
Contributor Author

elpaso commented Oct 14, 2021

@rouault gpkg removed.

@rouault rouault merged commit 0f3011b into qgis:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes - Update All button - Creates Corrupted Fields - GeoJSON file
2 participants