sipify gui editor widgets #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3nids
force-pushed
the
sipify_guieditorwidget
branch
7 times, most recently
from
d446512
to
c265e04
Compare
3nids
commented
May 8, 2017
| @@ -49,8 +49,6 @@ class GUI_EXPORT QgsRelationReferenceWidget : public QWidget | |||
| Q_PROPERTY( bool openFormButtonVisible READ openFormButtonVisible WRITE setOpenFormButtonVisible ) | |||
|
|
|||
| public: | |||
| typedef QPair < QVariant, QgsFeatureId > ValueRelationItem; | |||
| typedef QVector < ValueRelationItem > ValueRelationCache; | |||
There was a problem hiding this comment.
I removed these two as they were not used, is this ok for you @m-kuhn ?
there seem to be another similar definition in QgsValueRelationFieldFormatter which I suspect replaced this one.
3nids
force-pushed
the
sipify_guieditorwidget
branch
from
c265e04
to
fda37b7
Compare
nyalldawson
added a commit
to nyalldawson/QGIS
that referenced
this pull request
May 30, 2017
Label rotation is now specified in degrees clockwise, just like symbol rotation, map rotation, etc. Fix qgis#4518
mj10777
pushed a commit
to mj10777/QGIS
that referenced
this pull request
Aug 17, 2017
Label rotation is now specified in degrees clockwise, just like symbol rotation, map rotation, etc. Fix qgis#4518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.