Ensure labeling map tools only try to affect labels from vector layers #45311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
approved these changes
Oct 1, 2021
Labels from other layer types (eg vector tiles) are unsupported, which results in a crash. Fixes qgis#44486
layers which have been set for a canvas but which AREN'T part of QgsProject::instance() Required to fix test failure in labeling map tools, but ultimately a necessary piece of API to ensure that map tools aren't so tightly bound to QgsProject::instance()
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_16 release-3_16
# Navigate to the new working tree
cd .worktrees/backport-release-3_16
# Create a new branch
git switch --create backport-45311-to-release-3_16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick d5d61ed2a9e916aba5624bc70594ac657965c60d,aa8f982eb6398f8606cc544939c15c0fdbcc90a1,20cc8d8409abdcc52af0f005aa75e4279a51b3bf
# Push it to GitHub
git push --set-upstream origin backport-45311-to-release-3_16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_16Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels from other layer types (eg vector tiles) are unsupported,
which results in a crash.
Fixes #44486