Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure labeling map tools only try to affect labels from vector layers #45311

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Ensure labeling map tools only try to affect labels from vector layers #45311

merged 3 commits into from
Oct 5, 2021

Commits on Oct 4, 2021

  1. Ensure labeling map tools only try to affect labels from vector layers 

    Labels from other layer types (eg vector tiles) are unsupported,
which results in a crash.

Fixes qgis#44486
    @nyalldawson
    nyalldawson committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    d5d61ed View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Add api for map canvas/map tools to retrieve layers by ID, including 

    layers which have been set for a canvas but which AREN'T part of
QgsProject::instance()

Required to fix test failure in labeling map tools, but ultimately
a necessary piece of API to ensure that map tools aren't so tightly
bound to QgsProject::instance()
    @nyalldawson
    nyalldawson committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    aa8f982 View commit details
    Browse the repository at this point in the history

  2. Use updated api in labeling map tools to retrieve layers by ID

    @nyalldawson
    nyalldawson committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    20cc8d8 View commit details
    Browse the repository at this point in the history