Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX][Processing] R scripts do not have enough outputs #4571

Merged

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented May 16, 2017

R scripts in processing only supports Vector, Raster and Table.
This commit adds fix the file output and adds directory, number and string outputs.

#4545 porting to 2.18 release

R scripts in processing only supports Vector, Raster and Table.
This commit adds fix the file output and adds directory, number and string outputs.
@rldhont rldhont added this to the 2.18 milestone May 16, 2017
@rldhont rldhont requested review from alexbruy and volaya May 16, 2017 17:48
@rldhont
Copy link
Contributor Author

rldhont commented May 16, 2017

@gioman here is the port, can you test it ?

@gioman
Copy link
Contributor

gioman commented May 16, 2017

@rldhont yes sure.

@rldhont
Copy link
Contributor Author

rldhont commented May 16, 2017

@gioman thanks!

@rldhont
Copy link
Contributor Author

rldhont commented May 17, 2017

@gioman I have tested it, do you think, I can merge the PR ?

@gioman
Copy link
Contributor

gioman commented May 17, 2017

@rldhont

@gioman I have tested it, do you think, I can merge the PR ?

I haven't had the chance yet test. I would say go ahead and merge, if something surfaces later in my test I will let you know. Thanks!

@rldhont rldhont merged commit 70a25d6 into qgis:release-2_18 May 17, 2017
@rldhont rldhont deleted the release-2_18-processing-rscripts-outputs branch January 2, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants