Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add role logging for PostGIS versioning. #4643

Merged
merged 1 commit into from
Jun 22, 2018
Merged

[FEATURE] Add role logging for PostGIS versioning. #4643

merged 1 commit into from
Jun 22, 2018

Conversation

merkato
Copy link
Contributor

@merkato merkato commented May 29, 2017 •
edited by m-kuhn

Description

Add new column in PostGIS versioning plugin SQL for role/username.
Add SQL logic for functions and triggers.
Add new QLineEdit for column name.

Fix #14012

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@merkato
[FEATURE] Add role logging for PostGIS versioning.
31ab103 
Add new column in PostGIS versioning plugin SQL.
Add SQL logic for functions and triggers.
Add new QLineEdit for column name.
@pcav
Copy link
Member

pcav commented May 30, 2017

It would fix https://issues.qgis.org/issues/14012

@pcav
Copy link
Member

pcav commented Feb 25, 2018

Any progress on this? It would be good to have.

@m-kuhn m-kuhn closed this Apr 23, 2018
@m-kuhn m-kuhn reopened this Apr 23, 2018
@m-kuhn
Copy link
Member

m-kuhn commented Apr 23, 2018

Retriggering tests against latest master

@m-kuhn m-kuhn added this to the 3.4 milestone Jun 10, 2018
@nyalldawson nyalldawson removed the 3.4 label Jun 10, 2018
@nyalldawson nyalldawson added the Merge After Thaw For approved PRs which are ready to be merged as soon as master is thawed label Jun 22, 2018
@pcav
Copy link
Member

pcav commented Jun 22, 2018

Fixes https://issues.qgis.org/issues/14012

@m-kuhn m-kuhn merged commit cbde32f into qgis:master Jun 22, 2018
@qgib qgib mentioned this pull request May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
Feature Merge After Thaw For approved PRs which are ready to be merged as soon as master is thawed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@merkato @pcav @m-kuhn @nyalldawson