Fix save style api, crash when saving styles #46955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a specified ID already exists
…eturning error when layer_styles table not present
…ions This is not safe to do -- it causes a crash if the api is used in a background thread Fixes qgis#46954 Fixes qgis#46914
nyalldawson
added
API
nirvn
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the API for saving styles to database to remove the unsafe use of widgets (a confirmation QMessageBox) from the provider code. This was shown when a matching style already exists in the database, and causes a crash if this method is ever called from a non-main thread.
Now determining if a matching style already exists is a separate method, and the messagebox questions are only present in the client (app) code.
Fixes #46954
Fixes #46914