Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix save style api, crash when saving styles #46955

Merged
merged 12 commits into from
Jan 24, 2022
Merged

Fix save style api, crash when saving styles #46955

merged 12 commits into from
Jan 24, 2022

Commits on Jan 23, 2022

  1. [api] Add QgsProviderMetadata method to test whether a style with 

    a specified ID already exists
    @nyalldawson
    nyalldawson committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    c2abc1f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Add test for OGR

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    20d9e0e View commit details
    Browse the repository at this point in the history

  2. [mssql] Add layer styles tests, minor fixes for layer style handling

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    e18738c View commit details
    Browse the repository at this point in the history

  3. [postgres] Add styleExists test, minor fix for listStylesInDatabase r… 

    …eturning error when layer_styles table not present
    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    f0805c0 View commit details
    Browse the repository at this point in the history

  4. [spatialite] Unit tests, minor fixes for style handling

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    311a98e View commit details
    Browse the repository at this point in the history

  5. Add checks for existing styles and confirmation question to app classes

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    604b828 View commit details
    Browse the repository at this point in the history

  6. [api] Don't use widgets in QgsProviderMetadata::saveStyle implementat… 

    …ions

This is not safe to do -- it causes a crash if the api is used in
a background thread

Fixes qgis#46954
Fixes qgis#46914
    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2ea0fd6 View commit details
    Browse the repository at this point in the history

  7. Document new behaviour

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    43bcaac View commit details
    Browse the repository at this point in the history

  8. Fix build

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    35f5f0b View commit details
    Browse the repository at this point in the history

  9. Fix warnings

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    eecdd55 View commit details
    Browse the repository at this point in the history

  10. Address review

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    58b2481 View commit details
    Browse the repository at this point in the history

  11. Fix build

    @nyalldawson
    nyalldawson committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    5935b90 View commit details
    Browse the repository at this point in the history