Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading of file-based mbtiles vector MVT package via Data Source Manager (fix #36449) #47028

Merged
merged 2 commits into from
Jan 30, 2022
Merged

fix loading of file-based mbtiles vector MVT package via Data Source Manager (fix #36449) #47028

merged 2 commits into from
Jan 30, 2022

Conversation

alexbruy
Copy link
Contributor

Description

After configuring file-based vector MVT connection with the url like file:///path/to/file.mbtiles in the "Vector Tile" tab of the Data Source Manager it is not possible to add layer to project.

Seems for file-based MVT packages we should use type=mbtiles instead of type=xyz.

Fixes #36449.

@github-actions github-actions bot added this to the 3.24.0 milestone Jan 27, 2022
@alexbruy alexbruy added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jan 27, 2022
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for this too please?

@nyalldawson
Copy link
Collaborator

(this is a regression, so can skip the queued backport)

@alexbruy
Copy link
Contributor Author

Test added.

@alexbruy
Copy link
Contributor Author

(this is a regression, so can skip the queued backport)

Not sure it is a regression, seems it wasn't working this way from the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Vector tiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to add mbtiles file-based MVT package except drag and drop
2 participants