Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for field subtype to QgsFields::iconForFieldType #47086

Merged
merged 5 commits into from
Jan 31, 2022
Merged

Add support for field subtype to QgsFields::iconForFieldType #47086

merged 5 commits into from
Jan 31, 2022

Conversation

nyalldawson
Copy link
Collaborator

Adds support for showing array field type icons correctly, and shows field type icons in more contexts

Fixes #47078

@github-actions github-actions bot added this to the 3.24.0 milestone Jan 31, 2022
nirvn
nirvn approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it.

src/app/qgsnewspatialitelayerdialog.cpp Show resolved Hide resolved
@nyalldawson nyalldawson enabled auto-merge (rebase) January 31, 2022 07:38
@nyalldawson nyalldawson merged commit e95ff88 into qgis:master Jan 31, 2022
@nyalldawson nyalldawson deleted the enum_icons branch February 2, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirvn nirvn nirvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.24.0
Development

Successfully merging this pull request may close these issues.

Icon for array field types missing in the layer properties dialog's attribute form panel
2 participants
@nyalldawson @nirvn