Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't slightly colorise the icons for selected items in lists #47133

Merged

Conversation

nyalldawson
Copy link
Collaborator

This can result in misleading symbol icons in the legend, where
the icon will be slightly colorised to match the highlight color
of the selected list row background color.

We have to disable this across the whole application, but I can't
spot any fallout from this.

Also has a nice impact on symbols selected in the style manager
lists, as these no longer get incorrectly colorised either.

Refs #47065

This can result in misleading symbol icons in the legend, where
the icon will be slightly colorised to match the highlight color
of the selected list row background color.

We have to disable this across the whole application, but I can't
spot any fallout from this.

Also has a nice impact on symbols selected in the style manager
lists, as these no longer get incorrectly colorised either.

Refs qgis#47065
@github-actions github-actions bot added this to the 3.24.0 milestone Feb 1, 2022
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@nyalldawson nyalldawson enabled auto-merge (rebase) February 2, 2022 00:41
@nyalldawson nyalldawson merged commit b5ec05f into qgis:master Feb 2, 2022
@nyalldawson nyalldawson deleted the dontoverlaycoloronhighlightedicons branch February 4, 2022 01:11
@pathmapper
Copy link
Contributor

This fixed #44744, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants