Fix form pop-up suppress on relation-ref widget

[elpaso]

Fix #47226

[3nids]

I'm having a hard time understanding this fix.

QgsVectorLayerTools::setForceSuppressFormPopup is supposed to be able to set it both to True/False, no?

In the issue, it looks like the warning coming from the call to QgsEditFormConfig::legacyUpdateRelationWidgetInTabs should come only when opening an old project (pre 3.16).

I am wondering if we rather have some legacy config staying around while it should be dropped once converted.

[elpaso]

I'm having a hard time understanding this fix.

QgsVectorLayerTools::setForceSuppressFormPopup is supposed to be able to set it both to True/False, no?

I don't understand, this is what this fix does: previously the call was only setting it to true and it was impossible to revert it to false.

In the issue, it looks like the warning coming from the call to QgsEditFormConfig::legacyUpdateRelationWidgetInTabs should come only when opening an old project (pre 3.16).

I am wondering if we rather have some legacy config staying around while it should be dropped once converted.

Maybe, but the bug fixed here happened with a new project too so it's unrelated to the legacy settings.

[3nids]

I don't understand, this is what this fix does: previously the call was only setting it to true and it was impossible to revert it to false.

Sorry, I read the diff the opposite way 🥴