-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server crash (unreported) #47271
Conversation
Argh, I added a lot of unit tests but it wasn't enough... Can you add in these tests the filter string which is causing the issue please? |
I guess it just happens when there are no filters. |
Strange, there's already a test with an empty string filter. But the fix is still valid :). |
backport 3.22 ? |
I wasn't sure if #47029 landed in 3.22, if yes I think this needs backporting. |
Can you point me to the test? I'll run the debugger onto it. |
https://github.com/qgis/QGIS/blob/master/tests/src/python/test_qgsserver.py#L533-L538 |
That test crashes on my local machine without this patch. It hits
inline const QChar QString::at(int i) const
{ Q_ASSERT(uint(i) < uint(size())); return QChar(d->data()[i]); } So it was basically already covered by tests, I wonder why it didn't fail on CI, it is probably because |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_22 release-3_22
# Navigate to the new working tree
cd .worktrees/backport-release-3_22
# Create a new branch
git switch --create backport-47271-to-release-3_22
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 47d047ea313e0af89c686b634513deaec36d4c75
# Push it to GitHub
git push --set-upstream origin backport-47271-to-release-3_22
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_22 Then, create a pull request where the |
Followup #47029