Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the icon used for the reset button #4747

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Jun 18, 2017

@nirvn
Copy link
Contributor

nirvn commented Jun 19, 2017

@DelazJ , I'm +1 for the evis-related .ui changes, but I'm not sure it's that great to use a single icon to represent undo (i.e. going one step back) vs. clear/reset (i.e., wiping out all of the previous steps).

@DelazJ
Copy link
Contributor Author

DelazJ commented Jun 24, 2017

I'm not sure it's that great to use a single icon to represent undo (i.e. going one step back) vs. clear/reset (i.e., wiping out all of the previous steps)

Me neither! Do you mean there should be a new reset button (out of my skills) or is there already one that suits?
I guess some of the Options dialog reset buttons will also need updates in that case.

@DelazJ
Copy link
Contributor Author

DelazJ commented Jun 30, 2017

Reverted changes on the Refactor Field dialog

@m-kuhn
Copy link
Member

m-kuhn commented Jul 8, 2017

@nirvn can you take the lead here?

@nirvn nirvn merged commit 18c3634 into qgis:master Jul 10, 2017
@nirvn
Copy link
Contributor

nirvn commented Jul 10, 2017

@DelazJ , looking good. I've merged this as it is definitively a step in the right direction. We should eventually try and come up with a reset icon, but that can wait.

Thanks.

@DelazJ DelazJ deleted the resetbutton branch July 11, 2017 23:17
mj10777 pushed a commit to mj10777/QGIS that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants