Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set Qt::AA_ShareOpenGLContexts on all platforms #47873

Merged
merged 1 commit into from
Jul 31, 2022
Merged

set Qt::AA_ShareOpenGLContexts on all platforms #47873

merged 1 commit into from
Jul 31, 2022

Conversation

jbp35
Copy link
Contributor

@jbp35 jbp35 commented Mar 18, 2022

Description

Qt::AA_ShareOpenGLContexts needs to set in order to be able to use of QWebEngine in plugins (see QT doc in comments for detailed explanation).

Currently, it is always set to false due to a typo in the IF statement (it should be Q_OS_WIN and not QT_OS_WIN).

I don't see any reason why this should only be set on windows, so I suggest to remove this faulty check entirely in order to make it available on other platforms as well.

This is only a partial fix, two other things have to be addressed:

  • an issue with Pyqt binding which needs to be addressed upstream
  • python3-pyqt5-sip dependency has to be upgraded to API v12.9

@github-actions github-actions bot added this to the 3.26.0 milestone Mar 18, 2022
@github-actions
Copy link

github-actions bot commented Apr 2, 2022

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 2, 2022
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Apr 10, 2022
@nyalldawson nyalldawson reopened this Jul 29, 2022
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 30, 2022
@nyalldawson nyalldawson merged commit fd59c5a into qgis:master Jul 31, 2022
@nyalldawson
Copy link
Collaborator

@jbp35 I've had to revert this, as it breaks Qt 3D (and accordingly the QGIS 3d framework)

See details in #49888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants