set Qt::AA_ShareOpenGLContexts on all platforms #47873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Qt::AA_ShareOpenGLContexts needs to set in order to be able to use of QWebEngine in plugins (see QT doc in comments for detailed explanation).
Currently, it is always set to false due to a typo in the IF statement (it should be Q_OS_WIN and not QT_OS_WIN).
I don't see any reason why this should only be set on windows, so I suggest to remove this faulty check entirely in order to make it available on other platforms as well.
This is only a partial fix, two other things have to be addressed: