Avoid double free if QgsMapToolCapture is deleted after map canvas #48592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owned by a parent QObject E.g. QGraphicsItem subclasses are not QObjects themselves, but are owned by a QObject QGraphicsScene. Depending on whether the graphics item is deleted first or the scene, we can end up with a double-free situation. Fix this by creating a QObjectParentUniquePtr smart pointer which is automatically nulled if the parent QObject (e.g. the QGraphicsScene) is deleted first. (Adapted from existing QObjectUniquePtr logic and logic in QgsSnapIndicator)
github-actions
bot
added
the
GUI/UX
nirvn
approved these changes
May 22, 2022
| { | ||
| if ( p && !mParent ) | ||
| { | ||
| qWarning() << "Assigning pointer to QObjectParentUniquePtr with nullptr parent."; |
There was a problem hiding this comment.
You meant to use qWarning and not QgsDebugMsg here? Just checking.
There was a problem hiding this comment.
Yep -- it won't show unless something is very wrong, and I want the extra "in your face"-ness which qWarning gives us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.