Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes relation reference widget when filters are reset #4932

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

pblottiere
Copy link
Member

Description

This PR is the follow up of #4904.

When the Chain filter option is activated, items of combo boxes are correctly updated with values leading to actual features.

However there's still an issue when previous filters are reset (in this case, items of combo boxes are not properly updated). This PR fixes this issue.

A simple test have been added to highlight the issue.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@pblottiere pblottiere changed the title Fixes relation refernce widget when filters are reset Fixes relation refrence widget when filters are reset Jul 27, 2017
@pblottiere pblottiere changed the title Fixes relation refrence widget when filters are reset Fixes relation reference widget when filters are reset Jul 27, 2017
@mhugo mhugo merged commit ce22316 into qgis:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants