Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes relation reference widget when chain filter option is activated, fixes #16903 #4904

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

pblottiere
Copy link
Member

@pblottiere pblottiere commented Jul 21, 2017

Description

This PR fixes an issue regarding the relation reference widget : https://issues.qgis.org/issues/16903

When the Chain Filter option is activated, a filtering is now resolved on the fly with cached values in order to provide only filtering values (in combo boxes) leading to actual features.

Some tests have been added to validate the behavior.

See the initial discussion : qwat/QWAT#186

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@pblottiere pblottiere changed the title Fixes relation reference widget when chain filter option is activated Fixes relation reference widget when chain filter option is activated, fixes #16903 Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants