Fix unreported endless alg splitwithlines #50279
Conversation
elpaso
added
Processing
|
Nice! Can you add your test file please? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Lucky you, same change of mine but CI wind flowed in the right direction.
I'm approving this to help landing fixes.
Just for the record, my experience with CI and the SAME changes: https://github.com/qgis/QGIS/actions/runs/3114868919/jobs/5051179064#step:11:2995
Of course I'd love to see a testcase go with this fix, proving both the bug you reference in this PR and the bug I referenced in mine are fixed with this change. But I know it'd be very very hard.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@roya0045 pointed out that the C++ code was a port of a python code. It may be useful to dig the author of the initial python code to try at understanding which use case he/she had in mind with that recursion, since the testsuite didn't seem to notice the removal of it (lack of test for the usecase in mind?) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
For the record, I've filed this as GH-50316 |
Fix an unreported bug I discovered while investigating #50227 (unfortunately this PR does not fix that issue).
By adding the splitted geometries to ingeoms the while loop
while ( !inGeoms.empty() )was never ending and the inGeoms list was growing until all the available memory was exhausted.A simple test case was sufficient to reproduce the issue: