New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPS information panel UI and code rework #50753
Conversation
@nyalldawson A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
… type across different constellations
"Configure Device" button which directly opens the GPS options dialog Makes it easier for users to find the correct place to fix these settings
…ting "failed to connect" message bar warnings And show success message in message bar, instead of status bar
9f13a16
to
f86ae8b
Compare
@nyalldawson |
I think this breaks the QGIS start on windows (see https://trac.osgeo.org/osgeo4w/ticket/765). Back trace:
Apparently the dynamic initialization happens before the QMetaObject is initialized properly:
Findings: |
It seems the GPS Toolbar is enabled by default (it happens with new and old user profiles). @nyalldawson is this intended? I think it is not a toolbar to be enabled by default. |
Fixed in #50947 (applies to new profiles only unfortunately) |
This PR implements a substantial rework of the GPS information panel. The intention here is to simplify the user operation of GPS within QGIS and provide a more streamlined GPS experience.
Previously, ALL app level GPS functionality was exposed through the GPS "Information" panel. This included GPS connection settings, digitizing from GPS, and lastly... actually showing GPS information. It left us with a horrible dumping ground of all GPS settings and widgets and knobs and switches, giving a very disorganised UI which was confusing for users.
Now, the GPS functionality is split up:
(The last action in this menu opens the Settings - Options - GPS Pane)
The secondary intention was to clean up the app level GPS code, which until now was all tied heavily into the GPS information widget class. Now, that GPS information widget class is responsible ONLY for showing the GPS information in the panel, with new dedicated classes being created for handling digitizing from GPS, the new GPS toolbar, and GPS settings.
This PR will be followed up by several smaller changes which further improve GPS handling within QGIS app.
Sponsored by NIWA