[Backport release-3_22] Bugfix gh5122 mergefeature fid crash #51386
Conversation
src/app/qgisapp.cpp
Outdated
| QgsFeatureRequest request; | ||
| request.setFlags( QgsFeatureRequest::Flag::NoGeometry ); | ||
| // Handle multi pks | ||
| if ( vl->dataProvider()->pkAttributeIndexes().count() > 1 && vl->dataProvider()->pkAttributeIndexes().count() <= attrs.count() ) |
There was a problem hiding this comment.
@elpaso just noticing that at lines 10417 and 10420 vl->dataProvider() is checked for null. So for consistency this should also be tested here (or the previous tests are useless)
There was a problem hiding this comment.
ping @elpaso -- any chance we can get this one merged before the final 3.22 release?
There was a problem hiding this comment.
ping @domi4484 what's the status of this? Have you fixed it in the proper way and backported already or we have to backport this (which was intended as a temporary patch while we are waiting for a proper fix?)
There was a problem hiding this comment.
@elpaso just noticing that at lines 10417 and 10420 vl->dataProvider() is checked for null. So for consistency this should also be tested here (or the previous tests are useless)
Done (even if I believe that if data provider is null this method should exit much earlier).
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
github-actions
bot
added
stale
Backport #51125
Authored by: @elpaso