Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime Field edit config : not mixing display format and field format #51471

Merged
merged 2 commits into from
Feb 16, 2023
Merged

DateTime Field edit config : not mixing display format and field format #51471

merged 2 commits into from
Feb 16, 2023

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Jan 13, 2023

The default field datetime formats has to be const and equal to the international format. The default display datetime formats has to be localized.

Funded by 3liz https://3liz.com

@rldhont rldhont added API API improvement only, no visible user interface changes Forms GUI/UX Related to QGIS application GUI or User Experience labels Jan 13, 2023
@rldhont rldhont added this to the 3.30.0 milestone Jan 13, 2023
@rldhont rldhont force-pushed the fix-datetime-field-formatter-local-display branch from df2e3a9 to 7e029ab Compare January 16, 2023 11:22
@rldhont rldhont added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jan 16, 2023
@rldhont rldhont force-pushed the fix-datetime-field-formatter-local-display branch from 7e029ab to af28744 Compare January 16, 2023 18:40
@rldhont
Copy link
Contributor Author

rldhont commented Jan 17, 2023

The failing test is not related to this pull request : test_analysis_processingalgspt1

@rldhont rldhont requested review from 3nids and m-kuhn January 17, 2023 10:22
@rldhont rldhont force-pushed the fix-datetime-field-formatter-local-display branch from af28744 to 7672bfc Compare January 19, 2023 11:50
@rldhont
Copy link
Contributor Author

rldhont commented Jan 19, 2023

Thanks @3nids for the review. I have added comments.

@rldhont
Copy link
Contributor Author

rldhont commented Jan 24, 2023

Not related test failed : test_provider_copcprovider (Timeout)

@3nids
Copy link
Member

3nids commented Jan 27, 2023

@rldhont could you rebase?

@rldhont rldhont force-pushed the fix-datetime-field-formatter-local-display branch from 7672bfc to d34caa0 Compare January 27, 2023 08:39
@rldhont
Copy link
Contributor Author

rldhont commented Jan 27, 2023

@3nids rebase done

@rldhont
Copy link
Contributor Author

rldhont commented Jan 27, 2023

Unrelated tests failed:

  • 495 - PyQgsGeometryGeneratorSymbolLayer (Failed)
  • 607 - PyQgsNullSymbolRenderer (Failed)
  • 708 - PyQgsSingleSymbolRenderer (Failed)
  • 736 - PyQgsSymbolExpressionVariables (Failed)

@rldhont
DateTime Field edit config : not mixing display format and field format
5b42494 
The default field datetime formats has to be const and equal to the international format.
The default display datetime formats has to be localized.

Funded by 3liz https://3liz.com
@rldhont
[Server] WFS DescribeFeatureType: Using the const QgsDateTimeFieldFor…
a7c4519 
…matter::*_FORMAT to identify datetime format
@rldhont rldhont force-pushed the fix-datetime-field-formatter-local-display branch from d34caa0 to a7c4519 Compare January 30, 2023 08:20
@rldhont
Copy link
Contributor Author

rldhont commented Jan 30, 2023

All tests passed. Ready for merging ? @3nids

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 14, 2023
@rldhont
Copy link
Contributor Author

rldhont commented Feb 14, 2023

Waiting for reviews.

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 14, 2023
@3nids 3nids merged commit 58d1216 into qgis:master Feb 16, 2023
@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Feb 19, 2023
This was referenced Mar 2, 2023
Closed
Open
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3nids 3nids 3nids approved these changes

@m-kuhn m-kuhn Awaiting requested review from m-kuhn

Assignees
No one assigned
Labels
API API improvement only, no visible user interface changes ChangelogHarvested This PR description has been harvested in the Changelog already. Forms GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Milestone
3.30.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rldhont @3nids @zacharlie