Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid updating classification widgets which the user is editing #51720

Closed
wants to merge 1 commit into from
Closed

Avoid updating classification widgets which the user is editing #51720

wants to merge 1 commit into from

Conversation

nyalldawson
Copy link
Collaborator

Fixes #51687

Possible alternative to #51714

@github-actions github-actions bot added this to the 3.30.0 milestone Feb 3, 2023
@nyalldawson nyalldawson mentioned this pull request Feb 3, 2023
Merged
elpaso
elpaso reviewed Feb 6, 2023
View reviewed changes
src/gui/symbology/qgsgraduatedsymbolrendererwidget.cpp
const QgsProcessingParameterDefinition *def = ppww->parameterDefinition();
QVariant value = method->parameterValues().value( def->name(), def->defaultValueForGui() );
ppww->setParameterValue( value, context );
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson I've tested your branch again and debugged the code, it looks to me a no-op: the only case in which the mBlockClassificationMethodUpdates is != 0 is when it is called from the constructor.

In all other occasions it is called from QgsGraduatedSymbolRendererWidget::classificationMethodWidgetChanged when it is increased before the call.

I've even added an else branch and placed a breakpoint right here and it is never reached.

I must be missing something.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's because you were testing with your fix applied too -- indeed with your fix mBlockClassificationMethodUpdates will always be zero, because it's reset immediately before the deferred timer is called to perform the classification... I'll rework to avoid that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've updated accordingly (at a complexity cost 🙃 )

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 21, 2023
@nyalldawson nyalldawson removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 23, 2023
@nyalldawson nyalldawson modified the milestones: 3.30.0, 3.32 (feature) Mar 6, 2023
@YoannQDQ YoannQDQ modified the milestones: 3.32 (feature), 3.32.0 Mar 6, 2023
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 21, 2023
@nyalldawson
Copy link
Collaborator Author

@elpaso are you happy with this?

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 23, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 7, 2023
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso left review comments

Assignees
No one assigned
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Milestone
3.32.0
Development

Successfully merging this pull request may close these issues.

Weird interval QgsDoubleSpinbox behavior in graduated symbology with fixed interval
3 participants
@nyalldawson @elpaso @YoannQDQ