[3D] Fix Y-Z inversion in point3dsymbolwidget #51855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
added
3D
ptitjano
force-pushed
the
translation-y
branch
from
9b227f9
to
9602760
Compare
ptitjano
force-pushed
the
translation-y
branch
2 times, most recently
from
02ebb49
to
dc65257
Compare
wonder-sk
reviewed
Feb 20, 2023
Billboard height and translation along the Y axis are sync. The translation value can be negative. Therefore, the billboard height value can also be negative.
ptitjano
force-pushed
the
translation-y
branch
2 times, most recently
from
560673c
to
85ce36d
Compare
wonder-sk
approved these changes
Feb 20, 2023
auto-merge was automatically disabled
February 20, 2023 10:28
Head branch was pushed to by a user without write access
ptitjano
force-pushed
the
translation-y
branch
from
85ce36d
to
868bdd3
Compare
A point on the 2D plane (x', y') is transformed to (x, -z) in the 3D world. The rotation, scale and translation values of a point need to be converted in the 3D world. This change applies the correct transformation to have a correct binding between the 2D and 3D world.
ptitjano
force-pushed
the
translation-y
branch
from
868bdd3
to
0218ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A point on the 2D plane (x', y') is transformed to (x, -z) in the 3D world. It looks like
point3dsymbolwidgetdoes not handle this change. This MR fixes it.current behavior
new behavior
cc @benoitdm-oslandia @wonder-sk