Fix bug introduced by #51913 - Proxy EditorTab attributes to Editor #52036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoannQDQ
added
the
Bug
nyalldawson
reviewed
Feb 28, 2023
nyalldawson
reviewed
Mar 2, 2023
|
@YoannQDQ another issue I've noticed which has crept in is that after saving a script (via Ctrl+S), the tab name is not updated to show the newly saved filename. Is that fixed by this PR? |
|
Yes, it is :)
Yes it is! See comment above :) |
nyalldawson
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug introduced by #51913 (see #51913 (comment)) by proxying EditorTab attributes to Editor
Also fix some typo (
edisavewas written instead ofeditor.save)