[bugfix] Do not cache invalid WM(T)S responses #5289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here was that in case of http->https redirect from a misconfigured server (that advertizes http and then redirects all request to https) all http redirect requests were cached, making all subsequent requests to the same url hit the 301 Moved Permanently reponse page intead of the redirected content. Fixes qgis#16427 WMTS rendering problems in 2.18 and Master
|
@elpaso brillant! |
|
Are these the white tiles that sometimes appear? |
|
@m-kuhn I suppose yes, at least in this bug the unexpected behavior was the white tiles. |
|
Lovely! |
m-kuhn
reviewed
Oct 3, 2017
src/providers/wms/qgstilecache.cpp
Outdated
| if ( ! image.isNull( ) ) | ||
| { | ||
| sTileCache.insert( url, new QImage( image ) ); | ||
| return true; |
There was a problem hiding this comment.
If you want to make me even happier you define a return value on top and return it in the end.
bool success = false;
...
return success;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here was that in case of http->https redirect
from a misconfigured server (that advertizes http and then
redirects all request to https) all http redirect requests
were cached, making all subsequent requests to the same
url hit the 301 Moved Permanently reponse page instead of
the redirected content.
Fixes #16427 WMTS rendering problems in 2.18 and Master