Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations tools various improvements #53015

Merged
merged 5 commits into from
May 7, 2023

Conversation

YoannQDQ
Copy link
Contributor

@YoannQDQ YoannQDQ commented May 4, 2023

Description

This PR improve the behavior of annotation tools (Html, Text, Svg, Form and Move)

  • Do not resize annotation when the cursor is not actually over the frame
    resize_outside
  • Add a context menu (When an annotation tool is activated) on the annotation items
    annotation_context_menu
  • Drop the undocumented toggleTextItemVisibilities (when user presses Ctrl+T, toggle only the Text annotations visibility)
  • Improve the selection and resizing behavior. Notably better handles overlapping annotations by not considering that an annotation is under the mouse if neither its frame nor anchor point are actually under the cursor. The behavior exhibited below was impossible before, as the large annotation would have prevented from selecting the small one.
    resize-move-annotation

@github-actions github-actions bot added this to the 3.32.0 milestone May 4, 2023
@YoannQDQ YoannQDQ added Feature Bug Either a bug report, or a bug fix. Let's hope for the latter! labels May 4, 2023
@nyalldawson nyalldawson merged commit 5837820 into qgis:master May 7, 2023
26 of 27 checks passed
@YoannQDQ YoannQDQ deleted the annotations-context-menu branch May 8, 2023 05:20
@DelazJ DelazJ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label May 8, 2023
@qgis-bot
Copy link
Collaborator

qgis-bot commented May 8, 2023

@YoannQDQ
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

@YoannQDQ
A documentation ticket has been opened at qgis/QGIS-Documentation#8247
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jun 17, 2023
@qgis-bot
Copy link
Collaborator

@YoannQDQ

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Annotations Bug Either a bug report, or a bug fix. Let's hope for the latter! ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants